drbd: flush drbd work queue before invalidate/invalidate remote

Browse source

If you do back to back wait-sync/invalidate on a Primary in a tight loop,
during application IO load, you could trigger a race:
  kernel: block drbd6: FIXME going to queue 'set_n_write from StartingSync'
    but 'write from resync_finished' still pending?

Fix this by changing the order of the drbd_queue_work() and
the wake_up() in dec_ap_pending(), and adding the additional
drbd_flush_workqueue() before requesting the full sync.

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

...

This commit is contained in:

Lars Ellenberg 2012-07-30 09:11:38 +02:00 • committed by Philipp Reisner

parent 6f1a656325

commit 970fbde1f1

2 changed files with 12 additions and 6 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

10

drivers/block/drbd/drbd_int.h

View file

8

drivers/block/drbd/drbd_nl.c

View file