[PATCH] x86: consolidate smp_send_stop()

Browse source

Synchronize i386's smp_send_stop() with x86-64's in only try-locking
the call lock to prevent deadlocks when called from panic().
In both version, disable interrupts before clearing the CPU off the
online map to eliminate races with IRQ handlers inspecting this map.
Also in both versions, save/restore interrupts rather than disabling/
enabling them.
On x86-64, eliminate one function used here by folding it into its
single caller, convert to static, and rename for consistency with i386
(lkcd may like this).

Signed-off-by: Jan Beulich <jbeulich@novell.com>
Signed-off-by: Andi Kleen <ak@suse.de>

...

This commit is contained in:

Jan Beulich 2007-05-02 19:27:05 +02:00 • committed by Andi Kleen

parent b0354795c9

commit 9964cf7d77

3 changed files with 48 additions and 49 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

68

arch/i386/kernel/smp.c

View file

28

arch/x86_64/kernel/smp.c

View file

1

include/asm-x86_64/smp.h

View file