IB/hfi1: Fix infinite loop in 8051 command error path

Browse source

When an 8051 command times out, the entire DC block is restarted. During
the restart, the host interface version bit is set, which calls
do_8051_command() recursively. The host version bit needs to be set
before the link moves into polling, so the host version bit can be set
in set_local_link_attributes() instead. Thus, the 8051 command functions
can be simplied as a non-locking version (dd->dc8051_lock) of those
functions are no longer needed.

Fixes: 9be6a5d788 ("IB/hfi1: Prevent LNI out of sync by resetting host interface version")
Reviewed-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
Signed-off-by: Sebastian Sanchez <sebastian.sanchez@intel.com>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>

...

This commit is contained in:

Sebastian Sanchez 2017-12-18 19:56:59 -08:00 • committed by Doug Ledford

parent f5b53b0434

commit 9996b049f6

3 changed files with 46 additions and 102 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

82

drivers/infiniband/hw/hfi1/chip.c

View file

2

drivers/infiniband/hw/hfi1/chip.h

View file

64

drivers/infiniband/hw/hfi1/firmware.c

View file