s390/qeth: unregister netdevice only when registered

Browse source

[ Upstream commit 30356d0815 ]

qeth only registers its netdevice when the qeth device is first set
online. Thus a device that has never been set online will trigger
a WARN ("network todo 'hsi%d' but state 0") in unregister_netdev() when
removed.

Fix this by protecting the unregister step, just like we already protect
against repeated registering of the netdevice.

Fixes: d3d1b205e8 ("s390/qeth: allocate netdevice early")
Reported-by: Karsten Graul <kgraul@linux.ibm.com>
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

...

This commit is contained in:

Julian Wiedmann 2018-11-02 19:04:10 +01:00 • committed by Greg Kroah-Hartman

parent d005b563ae

commit 99b9de47a8

3 changed files with 11 additions and 4 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

5

drivers/s390/net/qeth_core.h

View file

5

drivers/s390/net/qeth_l2_main.c

View file

5

drivers/s390/net/qeth_l3_main.c

View file