drm/i915/pxp: Trigger the global teardown for before suspending

Browse source

A driver bug was recently discovered where the security firmware was
receiving internal HW signals indicating that session key expirations
had occurred. Architecturally, the firmware was expecting a response
from the GuC to acknowledge the event with the firmware side.
However the OS was in a suspended state and GuC had been reset.

Internal specifications actually required the driver to ensure
that all active sessions be properly cleaned up in such cases where
the system is suspended and the GuC potentially unable to respond.

This patch adds the global teardown code in i915's suspend_prepare
code path.

v2 : Split __pxp_global_teardown_locked helper into two variants
     for teardown-with-restart vs teardown-for-suspend/shutdown.

Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
Reviewed-by: Juston Li <justonli@chromium.org>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230125082637.118970-6-alan.previn.teres.alexis@intel.com

...

This commit is contained in:

Alan Previn 2023-01-25 00:26:36 -08:00 • committed by Rodrigo Vivi

parent d374c047b3

commit 9b469093d3

5 changed files with 66 additions and 13 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

65

drivers/gpu/drm/i915/pxp/intel_pxp.c

View file

1

drivers/gpu/drm/i915/pxp/intel_pxp.h

View file

2

drivers/gpu/drm/i915/pxp/intel_pxp_pm.c

View file

6

drivers/gpu/drm/i915/pxp/intel_pxp_session.c

View file

5

drivers/gpu/drm/i915/pxp/intel_pxp_session.h

View file