ALSA: usb-audio: scarlett2: Fix data_mutex lock

Browse source

The private->vol_updated flag was being checked outside of the
mutex_lock/unlock() of private->data_mutex leading to the volume data
being fetched twice from the device unnecessarily or old volume data
being returned.

Update scarlett2_*_ctl_get() and include the private->vol_updated flag
check inside the critical region.

Signed-off-by: Geoffrey D. Bennett <g@b4.vu>
Link: https://lore.kernel.org/r/20210620164643.GA9216@m.b4.vu
Signed-off-by: Takashi Iwai <tiwai@suse.de>

...

This commit is contained in:

Geoffrey D. Bennett 2021-06-21 02:16:43 +09:30 • committed by Takashi Iwai

parent 3eeb2a19db

commit 9b5ddea9ce

1 changed files with 9 additions and 12 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

21

sound/usb/mixer_scarlett_gen2.c

View file