[GFS2] Move pin/unpin into lops.c, clean up locking

Browse source

gfs2_pin and gfs2_unpin are only used in lops.c, despite being
defined in meta_io.c, so this patch moves them into lops.c and
makes them static. At the same time, its possible to clean up
the locking in the buf and databuf _lo_add() functions so that
we only need to grab the spinlock once. Also we have to move
lock_buffer() around the _lo_add() functions since we can't
do that in gfs2_pin() any more since we hold the spinlock
for the duration of that function.

As a result, the code shrinks by 12 lines and we do far fewer
operations when adding buffers to the log. It also makes the
code somewhat easier to read & understand.

Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

...

This commit is contained in:

Steven Whitehouse 2007-08-27 13:54:05 +01:00

parent eaf965270f

commit 9b9107a5a8

3 changed files with 89 additions and 101 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

117

fs/gfs2/lops.c

View file

70

fs/gfs2/meta_io.c

View file

3

fs/gfs2/meta_io.h

View file