ASoC: sun4i-i2s: Change get_sr() and get_wss() to be more explicit

Browse source

We are actually using a complex formula to just return a bunch of
simple values. Also this formula is wrong for sun4i when calling
get_wss() the function return 4 instead of 3.

Replace this with a simpler switch case.

Also drop the i2s params which is unused and return a simple int as
returning an error code could be out of range for an s8 and there is
no optim to return a s8 here.

Fixes: 619c15f7fa ("ASoC: sun4i-i2s: Change SR and WSS computation")
Reviewed-by: Chen-Yu Tsai <wens@csie.org>
Acked-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Clément Péron <peron.clem@gmail.com>
Link: https://lore.kernel.org/r/20201030144648.397824-5-peron.clem@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>

...

This commit is contained in:

Clément Péron 2020-10-30 15:46:37 +01:00 • committed by Mark Brown

parent 73adf87b7a

commit 9c2d255f0e

No known key found for this signature in database

GPG key ID: 24D68B725D5487D0

1 changed files with 44 additions and 25 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

69

sound/soc/sunxi/sun4i-i2s.c

View file