ASoC: ux500: Validate MSP DAI configuration

Browse source

Installing channel constraints from hw_params is too late to affect the
parameters being committed. The driver consequently accepts channel
counts which disagree with the I2S or TDM setup. It also silently
truncates out-of-range slot masks and accepts inverted bit clock formats
which prepare then rejects.

Validate the selected channel count directly, reject invalid masks
before changing cached TDM state, and implement all four standard clock
and frame inversion combinations. Use the requested format in
validation diagnostics.

Fixes: 3592b7f69a ("ASoC: Ux500: Add MSP I2S-driver")
Assisted-by: LLM
Signed-off-by: Linus Walleij <linusw@kernel.org>
Link: https://patch.msgid.link/20260902-ux500-msp-fixes-v2-4-4b60b002d55a@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>

...

This commit is contained in:

Linus Walleij 2026-09-02 09:55:54 +02:00 • committed by Mark Brown

parent 94c18cea65

commit 9ccbacf5a0

No known key found for this signature in database

GPG key ID: 24D68B725D5487D0

3 changed files with 33 additions and 16 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

41

sound/soc/ux500/ux500_msp_dai.c

View file

7

sound/soc/ux500/ux500_msp_i2s.c

View file

1

sound/soc/ux500/ux500_msp_i2s.h

View file