net: qualcomm: rmnet: kill RMNET_MAP_GET_*() accessor macros

Browse source

The following macros, defined in "rmnet_map.h", assume a socket
buffer is provided as an argument without any real indication this
is the case.
    RMNET_MAP_GET_MUX_ID()
    RMNET_MAP_GET_CD_BIT()
    RMNET_MAP_GET_PAD()
    RMNET_MAP_GET_CMD_START()
    RMNET_MAP_GET_LENGTH()
What they hide is pretty trivial accessing of fields in a structure,
and it's much clearer to see this if we do these accesses directly.

So rather than using these accessor macros, assign a local
variable of the map header pointer type to the socket buffer data
pointer, and derereference that pointer variable.

In "rmnet_map_data.c", use sizeof(object) rather than sizeof(type)
in one spot.  Also, there's no need to byte swap 0; it's all zeros
irrespective of endianness.

Signed-off-by: Alex Elder <elder@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Alex Elder 2021-03-15 16:51:48 -05:00 • committed by David S. Miller

parent 50c62a111c

commit 9d131d044f

4 changed files with 16 additions and 21 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

10

drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c

View file

12

drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h

View file

11

drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c

View file

4

drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c

View file