selftests/bpf: Remove duplicate copies of the arena spinlock qnodes

Browse source

bpf_arena_spin_lock.h defines its 64KB qnodes array in the header, so
every translation unit including it emits a copy. __weak makes them all
resolve to one instance, but bpftool gen object merges only the symbols
and concatenates each input's .addr_space.1 bytes, leaving the surplus
copies unreferenced in the linked object.

libarena links ten such units, so nine copies were dead weight (bytes):

  object                             before       after
  -----------------------------------------------------
  .addr_space.1 in libarena.bpf.o    676200       86376
  libarena.skel.h                   2100123      892371
  libarena_asan.skel.h              2641124     1466477

Declare qnodes in the header and let each program define it once:
libarena in src/common.bpf.c, and the arena_spin_lock test beside the
lock it guards.

Tested with test_progs -t arena_spin_lock and -t libarena.

Signed-off-by: Changwoo Min <changwoo@igalia.com>
Reviewed-by: Emil Tsalapatis <emil@etsalapatis.com>
Link: https://lore.kernel.org/bpf/20260817160249.655916-1-changwoo@igalia.com
Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>

...

This commit is contained in:

Changwoo Min 2026-08-18 01:02:49 +09:00 • committed by Kumar Kartikeya Dwivedi

parent 3d9393ff98

commit 9d19ca5d0e

No known key found for this signature in database

GPG key ID: 472D377B63542F83

3 changed files with 15 additions and 6 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

7

tools/testing/selftests/bpf/libarena/include/bpf_arena_spin_lock.h

View file

7

tools/testing/selftests/bpf/libarena/src/common.bpf.c

View file

7

tools/testing/selftests/bpf/progs/arena_spin_lock.c

View file