Fix race between cat /proc/*/wchan and rmmod et al

Browse source

kallsyms_lookup() can go iterating over modules list unprotected which is OK
for emergency situations (oops), but not OK for regular stuff like
/proc/*/wchan.

Introduce lookup_symbol_name()/lookup_module_symbol_name() which copy symbol
name into caller-supplied buffer or return -ERANGE.  All copying is done with
module_mutex held, so...

Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

...

This commit is contained in:

Alexey Dobriyan 2007-05-08 00:28:43 -07:00 • committed by Linus Torvalds

parent ffb4512276

commit 9d65cb4a17

7 changed files with 66 additions and 19 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

17

kernel/kallsyms.c

View file

23

kernel/module.c

View file

11

kernel/time/timer_list.c

View file

10

kernel/time/timer_stats.c

View file