[media] s5p-mfc: Don't allocate codec buffers on STREAMON

Browse source

Currently, we allocate private codec buffers on STREAMON, which may fail
if we are out of memory. We don't check for failure though, which will
make us crash with the codec accessing random memory.

We shouldn't be failing STREAMON with out of memory errors though. So move
the allocation of private codec buffers to REQBUFS for OUTPUT queue. Also,
move MFC instance opening and closing to REQBUFS as well, as it's tied to
allocation and deallocation of private codec buffers.

Signed-off-by: Pawel Osciak <posciak@chromium.org>
Signed-off-by: Arun Kumar K <arun.kk@samsung.com>
Signed-off-by: Kamil Debski <k.debski@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

...

This commit is contained in:

Pawel Osciak 2014-05-19 09:33:00 -03:00 • committed by Mauro Carvalho Chehab

parent 818cd91ab8

commit 9d87e8375d

3 changed files with 18 additions and 21 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

8

drivers/media/platform/s5p-mfc/s5p_mfc.c

View file

1

drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c

View file

30

drivers/media/platform/s5p-mfc/s5p_mfc_dec.c

View file