bcachefs: Accumulate accounting keys in journal replay

Browse source

Until accounting keys hit the btree, they are deltas, not new versions
of the existing key; this means we have to teach journal replay to
accumulate them.

Additionally, the journal doesn't track precisely which entries have
been flushed to the btree; it only tracks a range of entries that may
possibly still need to be flushed.

That means we need to compare accounting keys against the version in the
btree and only flush updates that are newer.

There's another wrinkle with the write buffer: if the write buffer
starts flushing accounting keys before journal replay has finished
flushing accounting keys, journal replay will see the version number
from the new updates and updates from the journal will be lost.

To avoid this, journal replay has to flush accounting keys first, and
we'll be adding a flag so that write buffer flush knows to hold
accounting keys until then.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

...

This commit is contained in:

Kent Overstreet 2023-12-27 20:59:01 -05:00

parent 2744e5c9eb

commit 9dec2a473b

5 changed files with 126 additions and 24 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

23

fs/bcachefs/btree_journal_iter.c

View file

15

fs/bcachefs/btree_journal_iter.h

View file

26

fs/bcachefs/btree_trans_commit.c

View file

14

fs/bcachefs/btree_update.h

View file

72

fs/bcachefs/recovery.c

View file