ASoC: SOF: Intel: hda: make DSPless mode work with DSP disabled in BIOS

Browse source

When the DSP is disabled in the BIOS, the DSP_BAR and PP_BAR cannot be
accessed.

One possible objection noted in initial reviews is that this patch
adds a number of branches. However the number of branches is actually
limited in probe/suspend/resume routines mostly, so there isn't really
a degradation in terms of readability and maintainability. Adding yet
another level of abstraction/ops/callbacks would increase complexity
and not really help in terms of code reuse or readability and
maintainability. A split between controller and DSP driver would be
even more invasive.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20230404092115.27949-7-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>

...

This commit is contained in:

Pierre-Louis Bossart 2023-04-04 12:21:09 +03:00 • committed by Mark Brown

parent 1f7b5d52be

commit 9fc6786f54

No known key found for this signature in database

GPG key ID: 24D68B725D5487D0

4 changed files with 107 additions and 45 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

30

sound/soc/sof/intel/hda-dsp.c

View file

3

sound/soc/sof/intel/hda-ipc.c

View file

25

sound/soc/sof/intel/hda-stream.c

View file

94

sound/soc/sof/intel/hda.c

View file