bnxt_re: Fix incorrect usage of test_bit()

Browse source

test_bit() takes a bit number while the 'flags' field in
struct bnxt_qplib_rcfw was using actual BIT position converted
values.
Fix this by assigning bit numbers and use consistent APIs
all the flag values.
Also logging a message in case of failure.

Thanks to Dan Carpenter for pointing this out.

Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>

...

This commit is contained in:

Somnath Kotur 2017-10-13 11:38:00 +05:30 • committed by Doug Ledford

parent 6a28d5a92c

commit a0ddc2ec8f

3 changed files with 10 additions and 9 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

5

drivers/infiniband/hw/bnxt_re/main.c

View file

8

drivers/infiniband/hw/bnxt_re/qplib_rcfw.c

View file

6

drivers/infiniband/hw/bnxt_re/qplib_rcfw.h

View file