ASoC: cs42l42: free_irq() before powering-down on probe() fail

Browse source

Relying on devm to free the irq handler on probe failure leaves a
small window of opportunity for an interrupt to become pending and
then the handler to run after the chip has been reset and powered
off.

For safety cs42l42_probe() should free the irq in the error path.
As the irq is now disabled by the driver in probe() and remove()
there is no point allocating it as a devres-managed item, so
convert to plain non-devres.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20211026125722.10220-3-rf@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>

...

This commit is contained in:

Richard Fitzgerald 2021-10-26 13:57:22 +01:00 • committed by Mark Brown

parent 6cb725b8a5

commit a10148a8cf

No known key found for this signature in database

GPG key ID: 24D68B725D5487D0

1 changed files with 11 additions and 8 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

19

sound/soc/codecs/cs42l42.c

View file