net: cxgb3: Cleanup in_interrupt() usage

Browse source

t3_sge_stop() is called from task context and from error handlers in
interrupt context. It relies on in_interrupt() to differentiate the
contexts.

in_interrupt() is deprecated as it is ill defined and does not provide what
it suggests.

Instead of replacing it with some other construct, simply split the
function into t3_sge_stop_dma(), which can be called from any context, and
t3_sge_stop() which can be only called from task context.

This has the advantage that any bogus invocation of t3_sge_stop() from
wrong contexts can be caught by debug kernels instead of being papered over
by the conditional.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Thomas Gleixner 2020-09-29 22:25:15 +02:00 • committed by David S. Miller

parent 453590a8b6

commit a17409e73b

3 changed files with 29 additions and 18 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

drivers/net/ethernet/chelsio/cxgb3/adapter.h

View file

2

drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c

View file

44

drivers/net/ethernet/chelsio/cxgb3/sge.c

View file