Merge branch 'mlxsw-Various-static-checkers-fixes'

Browse source

Ido Schimmel says:

====================
mlxsw: Various static checkers fixes

Jakub told me he gets some warnings with W=1, so I decided to check with
sparse, smatch and coccinelle as well. This patch set fixes all the
issues found. None are actual bugs / regressions and therefore not
targeted at net.

Patches #1-#2 add missing kernel-doc comments.

Patch #3 removes dead code.

Patch #4 reworks the ACL code to avoid defining a static variable in a
header file.

Patch #5 removes unnecessary conversion to bool that coccinelle warns
about.

Patch #6 avoids false-positive uninitialized symbol errors emitted by
smatch.
====================

Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

David S. Miller 2020-03-27 15:06:50 -07:00

parent 8a8f8281e7 a84acf7830

commit a1c7a536e0

6 changed files with 109 additions and 296 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

50

drivers/net/ethernet/mellanox/mlxsw/core_acl_flex_keys.c

View file

36

drivers/net/ethernet/mellanox/mlxsw/core_acl_flex_keys.h

View file

1

drivers/net/ethernet/mellanox/mlxsw/i2c.c

View file

152

drivers/net/ethernet/mellanox/mlxsw/spectrum_fid.c

View file

170

drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c

View file

2

drivers/net/ethernet/mellanox/mlxsw/switchx2.c

View file