drm/i915: Use kcalloc more

Browse source

No buffer overflows here, but better safe than sorry.

v2:
- Fixup the sizeof conversion, I've missed the pointer deref (Jani).
- Drop the redundant GFP_ZERO, kcalloc alreads memsets (Jani).
- Use kmalloc_array for the execbuf fastpath to avoid the memset
  (Chris). I've opted to leave all other conversions as-is since they
  aren't in a fastpath and dealing with cleared memory instead of
  random garbage is just generally nicer.

Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
[danvet: Drop the contentious kmalloc_array hunk in execbuf.]
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

...

This commit is contained in:

Daniel Vetter 2013-09-21 00:35:38 +02:00

parent b14c5679dd

commit a1e2265332

5 changed files with 10 additions and 9 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

3

drivers/gpu/drm/i915/i915_gem_execbuffer.c

View file

4

drivers/gpu/drm/i915/i915_gem_gtt.c

View file

6

drivers/gpu/drm/i915/i915_gem_tiling.c

View file

4

drivers/gpu/drm/i915/i915_gpu_error.c

View file

2

drivers/gpu/drm/i915/intel_display.c

View file