x86/io_apic: Cleanup trigger/polarity helpers

Browse source

'trigger' and 'polarity' are used throughout the I/O-APIC code for handling
the trigger type (edge/level) and the active low/high configuration. While
there are defines for initializing these variables and struct members, they
are not used consequently and the meaning of 'trigger' and 'polarity' is
opaque and confusing at best.

Rename them to 'is_level' and 'active_low' and make them boolean in various
structs so it's entirely clear what the meaning is.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20201024213535.443185-20-dwmw2@infradead.org

...

This commit is contained in:

Thomas Gleixner 2020-10-24 22:35:19 +01:00

parent 0c1883c1eb

commit a27dca645d

5 changed files with 130 additions and 147 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

6

arch/x86/include/asm/hw_irq.h

View file

244

arch/x86/kernel/apic/io_apic.c

View file

8

arch/x86/pci/intel_mid_pci.c

View file

10

drivers/iommu/amd/iommu.c

View file

9

drivers/iommu/intel/irq_remapping.c

View file