staging: rtl8712: Use completions for signaling

Browse source

r8712_sitesurvey_cmd() uses a variable to notify r8712_SetFilter() that it
has completed operation. There is no sort of assurance that the variable will
actually change and it could cache the value the first time it is read and
then never update it for the whole loop logic.

Use completion variables because they are better suited for the purpose.

This patch fixes the checkpatch.pl warnings like:
CHECK: Avoid CamelCase: <blnEnableRxFF0Filter>
+   u8 blnEnableRxFF0Filter;

Reviewed-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Signed-off-by: Sathish Kumar <skumark1902@gmail.com>
Link: https://lore.kernel.org/r/20220323045515.2513-1-skumark1902@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

...

This commit is contained in:

Sathish Kumar 2022-03-23 10:25:15 +05:30 • committed by Greg Kroah-Hartman

parent 52a0af7091

commit a3515f2053

4 changed files with 4 additions and 11 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

3

drivers/staging/rtl8712/drv_types.h

View file

2

drivers/staging/rtl8712/rtl871x_cmd.c

View file

2

drivers/staging/rtl8712/usb_intf.c

View file

8

drivers/staging/rtl8712/xmit_linux.c

View file