xfs: ensure sync write errors are returned

Browse source

xfs_file_aio_write() only returns the error from synchronous
flushing of the data and inode if error == 0. At the point where
error is being checked, it is guaranteed to be > 0. Therefore any
errors returned by the data or fsync flush will never be returned.
Fix the checks so we overwrite the current error once and only if an
error really occurred.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Alex Elder <aelder@sgi.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>

...

This commit is contained in:

Dave Chinner 2011-01-11 10:13:53 +11:00 • committed by Dave Chinner

parent d0eb2f38b2

commit a363f0c203

1 changed files with 23 additions and 26 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

49

fs/xfs/linux-2.6/xfs_file.c

View file