[NETFILTER]: nfnetlink_queue: fix checks in nfqnl_recv_config

Browse source

The peer_pid must be checked in all cases when a queue exists, currently
it is not checked if for NFQA_CFG_QUEUE_MAXLEN when a NFQA_CFG_CMD
attribute exists in some cases. Same for the queue existance check,
which can cause a NULL pointer dereference.

Also consistently return -ENODEV for "queue not found". -ENOENT would
be better, but that is already used to indicate a queued skb id doesn't
exist.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Patrick McHardy 2007-12-05 01:28:30 -08:00 • committed by David S. Miller

parent e48b9b2fb3

commit a3c8e7fd4b

1 changed files with 12 additions and 19 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

31

net/netfilter/nfnetlink_queue.c

View file