mv643xx_eth: avoid dropping tx lock during transmit reclaim

Browse source

By moving DMA unmapping during transmit reclaim back under the netif
tx lock, we avoid the situation where we read the DMA address and buffer
length from the descriptor under the lock and then not do anything with
that data after dropping the lock on platforms where the DMA unmapping
routines are all NOPs (which is the case on all ARM platforms that
mv643xx_eth is used on at least).

This saves two uncached reads, which makes a small but measurable
performance difference in routing benchmarks.

Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>

...

This commit is contained in:

Lennert Buytenhek 2008-09-13 04:16:15 +02:00 • committed by Lennert Buytenhek

parent 8fd89211bf

commit a418950c13

1 changed files with 7 additions and 15 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

22

drivers/net/mv643xx_eth.c

View file