drbd: fix bogus resync stats in /proc/drbd

Browse source

We intentionally do not serialize /proc/drbd access with
internal state changes or statistic updates.

Because of that, cat /proc/drbd  may race with resync just being
finished, still see the sync state, and find information about
number of blocks still to go, but then find the total number
of blocks within this resync has just been reset to 0
when accessing it.

This now produces bogus numbers in the resync speed estimates.

Fix by accessing all relevant data only once,
and fixing it up if "still to go" happens to be more than "total".

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

...

This commit is contained in:

Lars Ellenberg 2014-03-11 13:47:55 +01:00 • committed by Philipp Reisner

parent caa3db0e14

commit a5655dac75

2 changed files with 75 additions and 76 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

48

drivers/block/drbd/drbd_int.h

View file

103

drivers/block/drbd/drbd_proc.c

View file