drm/amd/display: Fix invalid DPIA AUX reply causing system hang

Browse source

[Why]
Some DPIA AUX replies have incorrect data length from original request.
This could lead to overwriting of destination buffer if reply length is
larger, which could cause invalid access to stack since many destination
buffers are declared as local variables.

[How]
Check for invalid length from DPIA AUX replies and trigger a retry if
reply length is not the same as original request. A DRM_WARN() dmesg log
is also produced.

Reviewed-by: Roman Li <Roman.Li@amd.com>
Acked-by: Tom Chung <chiahsuan.chung@amd.com>
Signed-off-by: Stylon Wang <stylon.wang@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org # 6.0.x

...

This commit is contained in:

Stylon Wang 2022-10-26 21:00:40 +08:00 • committed by Alex Deucher

parent be590ba8e2

commit a5d313b416

2 changed files with 20 additions and 6 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

20

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

View file

6

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h

View file