net: phy: marvell10g: fix differentiation of 88X3310 from 88X3340

Browse source

It seems that we cannot differentiate 88X3310 from 88X3340 by simply
looking at bit 3 of revision ID. This only works on revisions A0 and A1.
On revision B0, this bit is always 1.

Instead use the 3.d00d register for differentiation, since this register
contains information about number of ports on the device.

Fixes: 9885d016ff ("net: phy: marvell10g: add separate structure for 88X3340")
Signed-off-by: Marek Behún <kabel@kernel.org>
Reported-by: Matteo Croce <mcroce@linux.microsoft.com>
Tested-by: Matteo Croce <mcroce@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Marek Behún 2021-07-11 18:38:15 +02:00 • committed by David S. Miller

parent 84f7e0bb48

commit a5de4be0aa

2 changed files with 36 additions and 10 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

40

drivers/net/phy/marvell10g.c

View file

6

include/linux/marvell_phy.h

View file