drm/vc4: hdmi: Check the device state in prepare()

Browse source

Even though we already check that the encoder->crtc pointer is there
during in startup(), which is part of the open() path in ASoC, nothing
guarantees that our encoder state won't change between the time when we
open the device and the time we prepare it.

Move the sanity checks we do in startup() to a helper and call it from
prepare().

Link: https://lore.kernel.org/r/20211025141113.702757-8-maxime@cerno.tech
Fixes: 91e99e1139 ("drm/vc4: hdmi: Register HDMI codec")
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>

...

This commit is contained in:

Maxime Ripard 2021-10-25 16:11:11 +02:00

parent 633be8c3c0

commit a64ff88cb5

No known key found for this signature in database

GPG key ID: E3EF0D6F671851C5

1 changed files with 28 additions and 7 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

35

drivers/gpu/drm/vc4/vc4_hdmi.c

View file