qlcnic: Simplify DMA setting

Browse source

As stated in [1], dma_set_mask() with a 64-bit mask will never fail if
dev->dma_mask is non-NULL.
So, if it fails, the 32 bits case will also fail for the same reason.

So qlcnic_set_dma_mask(), (in qlcnic_main.c) can be simplified a lot and
inlined directly in its only caller.

If dma_set_mask_and_coherent() succeeds, 'pci_using_dac' is known to be 1.
So it can be removed from all the calling chain.

qlcnic_setup_netdev() can finally be simplified as-well.

[1]: https://lkml.org/lkml/2021/6/7/398

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/4996ab0337d62ec6a54b2edf234cd5ced4b4d7ad.1641649611.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

...

This commit is contained in:

Christophe JAILLET 2022-01-08 14:48:59 +01:00 • committed by Jakub Kicinski

parent 009e4ee381

commit a72dc1992d

6 changed files with 19 additions and 38 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

drivers/net/ethernet/qlogic/qlcnic/qlcnic.h

View file

2

drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.h

View file

4

drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c

View file

38

drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c

View file

2

drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov.h

View file

9

drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c

View file