drm/i915/uc: do not free err log on uc_fini

Browse source

We need to keep the GuC error logs around to debug the load failure,
so we can't clean them in the error unwind, which includes uc_fini().
Moving the cleanup to driver remove ensures that the logs stick around
long enough for us to dump them.

v2: reword commit msg (John)

Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Reviewed-by: John Harrison <John.C.Harrison@Intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20200326181121.16869-7-daniele.ceraolospurio@intel.com

...

This commit is contained in:

Daniele Ceraolo Spurio 2020-03-26 11:11:21 -07:00 • committed by Chris Wilson

parent 293a554801

commit a9410a6250

3 changed files with 9 additions and 4 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

3

drivers/gpu/drm/i915/gt/intel_gt.c

View file

9

drivers/gpu/drm/i915/gt/uc/intel_uc.c

View file

1

drivers/gpu/drm/i915/gt/uc/intel_uc.h

View file