net: ethernet: ti: cpts: move enable/disable flags outside of cpts module

Browse source

Each slave has it's own receive timestamp filter. But cpts rx/tx
timestamp enable flags are used to allow ts retrieve only for one
user. This limitation causes data path redundancy and setting overlap
if cpsw module is in dual-mac mode for instance.

If rx ts is enabled only for one port - the second interface must expect
every incoming packet to be PTP packet w/o absolutely any reason, and if
it's PTP - do unneeded stuff, as rx filter for second port is not set
and cpts fifo is not supposed to contain appropriate ts event.
That's not correct.

So, to fix control overlap and avoid redundant CPU cycles, the patch
splits rx/tx ts enable flags between network devices. After the patch,
PTP timestamping still should be used for only one port (or PTP id
counter has to be different for both ports as cpts IP is common).

Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Ivan Khoronzhuk 2018-11-12 16:00:22 +02:00 • committed by David S. Miller

parent f19dcd5f11

commit a942312034

4 changed files with 41 additions and 77 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

46

drivers/net/ethernet/ti/cpsw.c

View file

2

drivers/net/ethernet/ti/cpts.c

View file

38

drivers/net/ethernet/ti/cpts.h

View file

32

drivers/net/ethernet/ti/netcp_ethss.c

View file