iwlwifi: avoid race condition in channel change

Browse source

When iwl_mac_config() is called by mac80211, the channel pointer
hw->conf->channel can potentially change, resulting in mismatch
band and channel number when configuring RXON command. To avoid
this situation, save the channel pointer in local variables
and validate the channel before using it. Note that priv->mutex
is locked during the whole function so the local variables are safe.

Same change is applied to iwl_mac_channel_switch() since basically
it copies code from iwl_mac_config().

Also removed an outdated comment in the flow.

Signed-off-by: Shanyu Zhao <shanyu.zhao@intel.com>
Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>

...

This commit is contained in:

Shanyu Zhao 2010-07-28 13:40:39 -07:00 • committed by John W. Linville

parent 81e95430aa

commit aa2dc6b529

2 changed files with 12 additions and 16 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

14

drivers/net/wireless/iwlwifi/iwl-agn.c

View file

14

drivers/net/wireless/iwlwifi/iwl-core.c

View file