[media] v4l2: move tracepoints to video_usercopy

Browse source

The (d)qbuf ioctls were traced in the low-level v4l2 ioctl function. The
trace was outside the serialization lock, so that can affect the usefulness
of the timing. In addition, the __user pointer was expected instead of a
proper kernel pointer.

By moving the tracepoints to video_usercopy we ensure that the trace calls
use the correct kernel pointer, and that it happens right after the ioctl
call to the driver, so certainly inside the serialization lock.

In addition, we only trace if the call was successful.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Wade Farnsworth <wade_farnsworth@mentor.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

...

This commit is contained in:

Hans Verkuil 2013-12-16 05:45:37 -03:00 • committed by Mauro Carvalho Chehab

parent 3fe6d4b962

commit aa32f4c0bc

2 changed files with 9 additions and 9 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

9

drivers/media/v4l2-core/v4l2-dev.c

View file

9

drivers/media/v4l2-core/v4l2-ioctl.c

View file