nfp: core: make scalar CPP helpers fail on short accesses

Browse source

Currently the helpers for accessing 4 or 8 byte values over
the CPP bus return the length of IO on success.  If the IO
was short caller has to deal with error handling.  The short
IO for 4/8B values is completely impractical.  Make the
helpers return an error if full access was not possible.
Fix the few places which are actually dealing with errors
correctly, most call sites already only deal with negative
return codes.

Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Dirk van der Merwe <dirk.vandermerwe@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Jakub Kicinski 2018-01-17 18:50:55 -08:00 • committed by David S. Miller

parent 3c1693f012

commit aa3f4b69a7

4 changed files with 58 additions and 45 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

19

drivers/net/ethernet/netronome/nfp/nfp_net_debugdump.c

View file

42

drivers/net/ethernet/netronome/nfp/nfpcore/nfp_cppcore.c

View file

38

drivers/net/ethernet/netronome/nfp/nfpcore/nfp_cpplib.c

View file

4

drivers/net/ethernet/netronome/nfp/nfpcore/nfp_rtsym.c

View file