nfp: bpf: remember maps by ID

Browse source

Record perf maps by map ID, not raw kernel pointer.  This helps
with debug messages, because printing pointers to logs is frowned
upon, and makes debug easier for the users, as map ID is something
they should be more familiar with.  Note that perf maps are offload
neutral, therefore IDs won't be orphaned.

While at it use a rate limited print helper for the error message.

Reported-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Dirk van der Merwe <dirk.vandermerwe@netronome.com>
Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>

...

This commit is contained in:

Jakub Kicinski 2018-07-25 19:53:34 -07:00 • committed by Daniel Borkmann

parent 0958762748

commit ab01f4ac5f

5 changed files with 26 additions and 17 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

drivers/net/ethernet/netronome/nfp/bpf/cmsg.c

View file

12

drivers/net/ethernet/netronome/nfp/bpf/jit.c

View file

4

drivers/net/ethernet/netronome/nfp/bpf/main.c

View file

3

drivers/net/ethernet/netronome/nfp/bpf/main.h

View file

22

drivers/net/ethernet/netronome/nfp/bpf/offload.c

View file