IB/ipath: Fix SDMA error recovery in absence of link status change

Browse source

What's fixed:

    in ipath_cancel_sends()

        We need to unconditionally set ABORTING.  So, swap the tests
        so the set_bit() isn't shadowed by the &&.

        If we've disarmed the piobufs, then we need to unconditionally
        set DISARMED.  So, move it out from the overly protective if
        at the bottom.

    in sdma_abort_task()

        Abort_task was written knowing that the SDMA engine would always
        be reset (and restarted) on error.  A recent change broke that
        fundamental assumption by taking the restart portion and making
        it conditional on a link status change.  But, SDMA can go boom
        without a link status change in some conditions.

Signed-off-by: John Gregor <john.gregor@qlogic.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>

...

This commit is contained in:

John Gregor 2008-05-07 11:01:10 -07:00 • committed by Roland Dreier

parent e2ab41cae4

commit ab69b3cf12

2 changed files with 29 additions and 10 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

8

drivers/infiniband/hw/ipath/ipath_driver.c

View file

31

drivers/infiniband/hw/ipath/ipath_sdma.c

View file