drm/amdkfd: Fix goto usage v2

Browse source

Remove gotos that do not feature any common cleanup, and use gotos
instead of repeating cleanup commands.

According to kernel.org: "The goto statement comes in handy when a
function exits from multiple locations and some common work such as
cleanup has to be done. If there is no cleanup needed then just return
directly."

v2: Applied review suggestions in create_queue_nocpsch

Signed-off-by: Kent Russell <kent.russell@amd.com>
Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
Reviewed-by: Oded Gabbay <oded.gabbay@gmail.com>
Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>

...

This commit is contained in:

Kent Russell 2017-08-15 23:00:07 -04:00 • committed by Oded Gabbay

parent 4eacc26b3b

commit ab7c164867

5 changed files with 66 additions and 82 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

15

drivers/gpu/drm/amd/amdkfd/kfd_chardev.c

View file

102

drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c

View file

3

drivers/gpu/drm/amd/amdkfd/kfd_module.c

View file

14

drivers/gpu/drm/amd/amdkfd/kfd_packet_manager.c

View file

14

drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c

View file