libata: clear SError after link resume

Browse source

SError used to be cleared in ->postreset.  This has small hotplug race
condition.  If a device is plugged in after reset is complete but
postreset hasn't run yet, its hotplug event gets lost when SError is
cleared.  This patch makes sata_link_resume() clear SError.  This
kills the race condition and makes a lot of sense as some PMP and host
PHYs don't work properly without SError cleared.

This change makes sata_pmp_std_{pre|post}_reset()'s unnecessary as
they become identical to ata_std counterparts.  It also simplifies
sata_pmp_hardreset() and ahci_vt8251_hardreset().

Signed-off-by: Tejun Heo <htejun@gmail.com>

...

This commit is contained in:

Tejun Heo 2008-04-07 22:47:19 +09:00 • committed by Jeff Garzik

parent 57c9efdfb3

commit ac371987a8

4 changed files with 23 additions and 112 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

5

drivers/ata/ahci.c

View file

35

drivers/ata/libata-core.c

View file

93

drivers/ata/libata-pmp.c

View file

2

include/linux/libata.h

View file