netfilter: x_tables: fix pointer leaks to userspace

Browse source

[ Upstream commit 1e98ffea5a ]

Several netfilter matches and targets put kernel pointers into
info objects, but don't set usersize in descriptors.
This leads to kernel pointer leaks if a match/target is set
and then read back to userspace.

Properly set usersize for these matches/targets.

Found with manual code inspection.

Fixes: ec23189049 ("xtables: extend matches and targets with .usersize")
Signed-off-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

...

This commit is contained in:

Dmitry Vyukov 2018-01-29 13:21:20 +01:00 • committed by Greg Kroah-Hartman

parent 2b7cc93682

commit ad10785a70

5 changed files with 5 additions and 2 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

net/netfilter/xt_IDLETIMER.c

View file

1

net/netfilter/xt_LED.c

View file

3

net/netfilter/xt_limit.c

View file

1

net/netfilter/xt_nfacct.c

View file

1

net/netfilter/xt_statistic.c

View file