netfilter: x_tables: misuse of try_then_request_module

Browse source

Since xt_find_match() returns ERR_PTR(xx) on error not NULL,
the macro try_then_request_module won't work correctly here.
The macro expects its first argument will be zero if condition
fails. But ERR_PTR(-ENOENT) is not zero.

The correct solution is to propagate the error value
back.

Found by inspection, and compile tested only.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>

...

This commit is contained in:

Stephen Hemminger 2011-03-09 14:14:26 +01:00 • committed by Patrick McHardy

parent 9846ada138

commit adb00ae2ea

1 changed files with 15 additions and 7 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

22

net/netfilter/x_tables.c

View file