net: hisilicon: fix the return value handle and remove redundant netdev_err() for platform_get_irq()

Browse source

There is no possible for platform_get_irq() to return 0
and the return value of platform_get_irq() is more sensible
to show the error reason.

And there is no need to call the netdev_err() function directly to print
a custom message when handling an error from platform_get_irq() function as
it is going to display an appropriate error message in case of a failure.

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20230731073858.3633193-1-ruanjinjie@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

...

This commit is contained in:

Ruan Jinjie 2023-07-31 15:38:58 +08:00 • committed by Jakub Kicinski

parent 34093c9fa0

commit ae1d60c41e

3 changed files with 6 additions and 7 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

drivers/net/ethernet/hisilicon/hip04_eth.c

View file

4

drivers/net/ethernet/hisilicon/hisi_femac.c

View file

5

drivers/net/ethernet/hisilicon/hix5hd2_gmac.c

View file