spi: Don't use the message queue if possible in spi_sync

Browse source

The interaction with the controller message queue and its corresponding
auxiliary flags and variables requires the use of the queue_lock which is
costly. Since spi_sync will transfer the complete message anyway, and not
return until it is finished, there is no need to put the message into the
queue if the queue is empty. This can save a lot of overhead.

As an example of how significant this is, when using the MCP2518FD SPI CAN
controller on a i.MX8MM SoC, the time during which the interrupt line
stays active (during 3 relatively short spi_sync messages), is reduced
from 98us to 72us by this patch.

Signed-off-by: David Jander <david@protonic.nl>
Link: https://lore.kernel.org/r/20220621061234.3626638-3-david@protonic.nl
Signed-off-by: Mark Brown <broonie@kernel.org>

...

This commit is contained in:

David Jander 2022-06-21 08:12:25 +02:00 • committed by Mark Brown

parent 1714582a3a

commit ae7d2346dc

No known key found for this signature in database

GPG key ID: 24D68B725D5487D0

2 changed files with 159 additions and 98 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

246

drivers/spi/spi.c

View file

11

include/linux/spi/spi.h

View file