sfc: Fix ordering of device registration and initial netif_carrier_off()

Browse source

We must call netif_carrier_off() after the device is registered, not
before, to set the operational state and user-space IFF_RUNNING flag
correctly.

Since we don't want observers to see an intermediate state, open-code
register_netdev() and add efx_update_name() and netif_carrier_off()
into the locked region.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Ben Hutchings 2009-08-26 08:16:27 +00:00 • committed by David S. Miller

parent 7c6a3ed5bd

commit aed0628dae

1 changed files with 17 additions and 9 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

26

drivers/net/sfc/efx.c

View file