drbd: fix for spurious fullsync (uuids rotated too fast)

Browse source

If it was an "empty" resync, the SyncSource may have already "finished"
the resync and rotated the UUIDs, before noticing the connection loss
(and generating a new uuid, if Primary, rotating again), while the
SyncTarget did not change its uuids at all, or only got to the previous
sync-uuid.
This would then again lead to a full sync on next handshake
(see also Bug #251).

Fix:
Use explicit resync finished notification even for empty resyncs,
do not finish an empty resync implicitly on the SyncSource.

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

...

This commit is contained in:

Lars Ellenberg 2010-10-07 16:07:55 +02:00 • committed by Philipp Reisner

parent e9ef7bb6f9

commit af85e8e83d

2 changed files with 36 additions and 11 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

5

drivers/block/drbd/drbd_main.c

View file

42

drivers/block/drbd/drbd_worker.c

View file