[media] ivtv: ivtv_write_vbi() should use copy_from_user() for user data buffers

Browse source

ivtv_write_vbi() is used for both VBI data that came from the
driver internally and VBI data that came from the user.  However,
it did not use copy_from_user() for reading the VBI data from the
user buffers.

This change adds a new version of the function,
ivtv_write_vbi_from_user(), that uses copy_from_user() to read the VBI
data provided via user buffers.

This should resolve a sparse build warning reported by Dave Gilbert.

Reported-by: Dr. David Alan Gilbert <linux at treblig.org>
Signed-off-by: Andy Walls <awalls@md.metrocast.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

...

This commit is contained in:

Andy Walls 2010-12-18 10:48:17 -03:00 • committed by Mauro Carvalho Chehab

parent 754f9969c3

commit b0c45686c8

3 changed files with 78 additions and 38 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

3

drivers/media/video/ivtv/ivtv-fileops.c

View file

113

drivers/media/video/ivtv/ivtv-vbi.c

View file

4

drivers/media/video/ivtv/ivtv-vbi.h

View file