ocfs2/dlm: Fix race in adding/removing lockres' to/from the tracking list

Browse source

This patch adds a new lock, dlm->tracking_lock, to protect adding/removing
lockres' to/from the dlm->tracking_list. We were previously using dlm->spinlock
for the same, but that proved inadequate as we could be freeing a lockres from
a context that did not hold that lock. As the new lock only protects this list,
we can explicitly take it when removing the lockres from the tracking list.

This bug was exposed when testing multiple processes concurrently flock() the
same file.

Signed-off-by: Sunil Mushran <sunil.mushran@oracle.com>
Signed-off-by: Mark Fasheh <mfasheh@suse.com>

...

This commit is contained in:

Sunil Mushran 2008-12-16 15:49:22 -08:00 • committed by Mark Fasheh

parent d4f7e650e5

commit b0d4f817ba

4 changed files with 38 additions and 29 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

3

fs/ocfs2/dlm/dlmcommon.h

View file

53

fs/ocfs2/dlm/dlmdebug.c

View file

1

fs/ocfs2/dlm/dlmdomain.c

View file

10

fs/ocfs2/dlm/dlmmaster.c

View file