netfilter: x_tables: add and use xt_check_proc_name

Browse source

recent and hashlimit both create /proc files, but only check that
name is 0 terminated.

This can trigger WARN() from procfs when name is "" or "/".
Add helper for this and then use it for both.

Cc: Eric Dumazet <eric.dumazet@gmail.com>
Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
Reported-by: <syzbot+0502b00edac2a0680b61@syzkaller.appspotmail.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

...

This commit is contained in:

Florian Westphal 2018-03-10 01:15:45 +01:00 • committed by Pablo Neira Ayuso

parent 932909d9b2

commit b1d0a5d0cb

4 changed files with 45 additions and 9 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

include/linux/netfilter/x_tables.h

View file

30

net/netfilter/x_tables.c

View file

16

net/netfilter/xt_hashlimit.c

View file

6

net/netfilter/xt_recent.c

View file