mlx5: Use proper logging and tracing line terminations

Browse source

netdev_err should use newline termination but mlx5_health_report
is used in a trace output function devlink_health_report where
no newline should be used.

Remove the newlines from a couple formats and add a format string
of "%s\n" to the netdev_err call to not directly output the
logging string.

Also use snprintf to avoid any possible output string overrun.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>

...

This commit is contained in:

Joe Perches 2020-02-11 14:32:47 -08:00 • committed by Saeed Mahameed

parent 0f56d3c5d8

commit b21aef7e71

3 changed files with 11 additions and 10 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

drivers/net/ethernet/mellanox/mlx5/core/en/health.c

View file

9

drivers/net/ethernet/mellanox/mlx5/core/en/reporter_rx.c

View file

10

drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c

View file