drm/vkms: Add typedef and documentation for pixel_read and pixel_write functions

Browse source

Introduce two typedefs: pixel_read_t and pixel_write_t. It allows the
compiler to check if the passed functions take the correct arguments.
Such typedefs will help ensuring consistency across the code base in
case of update of these prototypes.

Rename input/output variable in a consistent way between read_line and
write_line.

A warn has been added in get_pixel_*_function to alert when an unsupported
pixel format is requested. As those formats are checked before
atomic_update callbacks, it should never happen.

Document for those typedefs.

Reviewed-by: Pekka Paalanen <pekka.paalanen@collabora.com>
Reviewed-by: José Expósito <jose.exposito89@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241118-yuv-v14-3-2dbc2f1e222c@bootlin.com
Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>

...

This commit is contained in:

Louis Chauvet 2024-11-18 19:28:18 +01:00

parent 2f9741ac3b

commit b21b580e57

No known key found for this signature in database

GPG key ID: 20AD2EC65B102CE2

4 changed files with 94 additions and 59 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

23

drivers/gpu/drm/vkms/vkms_drv.h

View file

124

drivers/gpu/drm/vkms/vkms_formats.c

View file

4

drivers/gpu/drm/vkms/vkms_formats.h

View file

2

drivers/gpu/drm/vkms/vkms_plane.c

View file